refs #36243 - Templates - Return Foreman's API status code

[stejskalleos]

Bugfixes and improvements

refs 70073c0

[Ron-Lavi]

@ekohl could you take a look at this one? it should address your concerns about the previous PR

[Ron-Lavi]

Hey @ekohl, any thoughts about this one? thanks

[ekohl]

Apologies for not getting to this. I'm not sure I like the already too complex method.

Have you considered to call it as log_halt(e.status_code, e, msg). So taking one example:

get "/:kind/:template/:hostgroup" do |kind, template, hostgroup|
  log_halt(nil, "Failed to retrieve #{kind} hostgroup template for #{params.inspect}: ") do
    Proxy::Templates::TemplateProxyRequest.new.get([kind, template, hostgroup], request.env, params)
  end
end

I wonder if you can rewrite it as:

get "/:kind/:template/:hostgroup" do |kind, template, hostgroup|
  Proxy::Templates::TemplateProxyRequest.new.get([kind, template, hostgroup], request.env, params)
rescue StandardError => e
  log_halt(e.status_code, e, "Failed to retrieve #{kind} hostgroup template for #{params.inspect}: ")
end

Given we're branching tomorrow I'm going merge it since it at least makes the code safer.