Fixes #37413 - Let the kernel assign a TCP port in tests #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
37413-let-kernel-allocate-port
branch
from
367c40d
to
83c33ed
Compare
ekohl
changed the title
dosas
approved these changes
May 8, 2024
ekohl
commented
May 8, 2024
| end | ||
| Timeout.timeout(2) do | ||
| sleep(0.1) until can_connect?('localhost', @settings.send("#{protocol}_port")) | ||
| sleep(0.1) until can_connect?('localhost', @settings["#{protocol}_port"]) |
There was a problem hiding this comment.
Technically this change isn't needed, but it feels more consistent if we're also setting it as a hash on line 49.
| end | ||
| end | ||
|
|
||
| def can_connect?(host, port) | ||
| return false if port == 0 |
There was a problem hiding this comment.
This took me a while to figure out, but the server is started in a thread, so the port isn't immediately set.
This binds on port 0, which lets the kernel decide which port to use. The port is then read back from the listener. Because the kernel knows which ports it's allowed to bind to, it removes the risk of a failure due to collisions or policies.
ekohl
force-pushed
the
37413-let-kernel-allocate-port
branch
from
83c33ed
to
bf8b44f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This binds on port 0, which lets the kernel decide which port to use. The port is then read back from the listener. Because the kernel knows which ports it's allowed to bind to, it removes the risk of a failure due to collisions or policies.