Fixes #32775 - use directly smart_proxy_rex_ssh #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ForemanRemoteExecution has been discontinued and has been moved to smart_proxy_remote_execution_ssh. We should use those classes directly and not rely on the compatibility layer rex_core gem.
|
Not sure what the test failures are about though |
|
Those are fairly strange. do we want to finalize #24 and see if the issue is only on Jenkins? |
Sounds good |
|
[test smart_proxy_ansible] |
|
Thank you @ezr-ondrej ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ForemanRemoteExecution has been discontinued and has been moved to
smart_proxy_remote_execution_ssh. We should use those classes directly
and not rely on the compatibility layer rex_core gem.