Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22141 - Remove sinatra/rack dependencies #42

Merged
merged 1 commit into from Jan 23, 2018
Merged

Fixes #22141 - Remove sinatra/rack dependencies #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion smart_proxy_dynflow_core.gemspec
View file
Open in desktop
Expand Up @@ -34,7 +34,7 @@ Gem::Specification.new do |gem|
gem.add_runtime_dependency('foreman-tasks-core', '>= 0.1.7')
gem.add_runtime_dependency('sequel')
gem.add_runtime_dependency('sqlite3')
gem.add_runtime_dependency('sinatra', '~> 1.4')
gem.add_runtime_dependency('sinatra')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be >= 1.4 instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be ok with whatever we get from the proxy, so I'm ok with this way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core part doesn't have to run with the proxy I think but I agree that chance is remote.

gem.add_runtime_dependency('rack')
gem.add_runtime_dependency('rest-client')
end