Fixes #26374 - use proxy code for authorization #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, I've made the core authorization code a bit more defensive: I've noticed that Puma is setting 'https' in `ENV['HTTPS']`: if we don't check that we should use https, we would be letting the requests though even if we shouldn't. Luckily, we're not running Puma just yet, but it's good to be prepared.
I don't remember last time it actually was useful.
iNecas
commented
Mar 19, 2019
| @@ -86,7 +86,7 @@ Style/Next: | |||
| Enabled: false | |||
|
|
|||
| Metrics/AbcSize: | |||
| Max: 30 | |||
| Enabled: false | |||
There was a problem hiding this comment.
Inspired by theforeman/smart-proxy@21642e6, I don't remember last time the AbcSize metric was of any use for me.
|
A lot has changed since this PR was opened and it isn't really needed anymore so I'll go ahead and close it. Thank you @iNecas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I've made the core authorization code a bit more defensive:
I've noticed that Puma is setting 'https' in
ENV['HTTPS']: if we don'tcheck that we should use https, we would be letting the requests though
even if we shouldn't. Luckily, we're not running Puma just yet, but it's
good to be prepared, so we're actually also checking whether we really
are not using https. Also, just the presence of
ENV['HTTPS']is nowenough to assume we are in the SSL mode.