-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite synchronize-npm-tags
in Node
#66
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📣 NOTIFICATION Generated by @thefrontside/actions |
13 tasks
3 tasks
minkimcello
changed the title
[WIP] Rewrite
Rewrite Apr 28, 2022
synchronize-npm-tags
in Nodesynchronize-npm-tags
in Node
Merged
taras
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current
synchronize-npm-tags
action does not support monorepos yet, and we have a lot of stale NPM tags onbigtest
andeffection
:Approach
What's New?
npm dist-tag ls
from the root so it worked fine for a normal repository but wouldn't work for a monorepo. The new action looks something like this:PRESERVE
argument for users to specify tags they want to keep even if there are no corresponding branchesbeta
,alpha
,dev
, andlatest
. These are included regardless of if users specify their own tags._
with__
and then replacing/
with_
. The new preview action replaces both_
and/
with a-
. This newsynchronize-npm-tags
action will take the list of branches and convert them into both formats in order to determine if it should be removed or not to ensure that active NPM tags will be preserved regardless of if they were generated by the old or new preview action.Other Stuff
@frontside/actions-utils
.TODOs
Should I include any other default protected tags to the list?Add tests