-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite synchronize-with-npm
in Node
#67
Conversation
📣 NOTIFICATION Generated by @thefrontside/actions |
8737ce1
to
f48b44d
Compare
509610f
to
323e09c
Compare
323e09c
to
48c1f28
Compare
@cowboyd Is there a correct way to write tests for both the |
synchronize-with-npm
in Nodesynchronize-with-npm
in Node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Motivation
To rewrite the release action in typescript.
Approach
What's New?
IGNORE
andNPM_PUBLISH
arguments. Similar to what was done in #65. We're skipping packages marked as private and we're usingnpm publish
for all publishing (as opposed to giving the users the ability to provide their own publish command likeyarn publish
)BEFORE_ALL
withINSTALL_SCRIPT
TODOs
Write testssynchronize-npm-tags
in Node #66 first and switch base branch of this PR tomain
.