Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imports not used when using multi-root workspaces for website development in VSCode #893

Open
taras opened this issue Feb 15, 2024 · 2 comments

Comments

@taras
Copy link
Member

taras commented Feb 15, 2024

VSCode Deno plugin does not read deno.json when used in multi-root workspace configuration. www/deno.json has imports path for Effection in other dependencies which Deno LSP does not know how to resolve which causes the following error

image
taras added a commit that referenced this issue Feb 15, 2024
@cowboyd
Copy link
Member

cowboyd commented Feb 15, 2024

@taras Does the workaround in that issue work?

@taras
Copy link
Member Author

taras commented Feb 15, 2024

No, because it's not the same issue. Our issue isn't that deno.json is in a folder. The problem is that it only reads the deno.json of the root workspace. The workaround in #894 is to make www root, which automatically reads the deno.json with imports relying on the fact that the core doesn't have any imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants