Feature/services user realms #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,37 +48,98 @@ describe('user', function () { | |||
| }); | |||
| } | |||
|
|
|||
| beforeEach(function (done) { | |||
| dao.deleteAllUsers(function (err) { | |||
| function configOptions(port, path, method, body, auth, version) { | |||
There was a problem hiding this comment.
In Node (or JavaScript in general), if you have a function with lots of input parameters it may be considered a code-smell. Its really hard to read function calls like configOptions('/test', 'GET', true, null, false, true). I'd rather have calls like this:
configOptions({
url: '/test',
method: 'GET',
body: {/* some object */},
auth: false,
version: true
});
Of course, this became obvious only after you made this refactor. And we have worst duplication problems. So, 👍 to you!
There was a problem hiding this comment.
You're right thx for the catch up. I'll change its signature as soon as i have 5 free mins 👍
Merged
|
Merged into #103 |
luismesas
added a commit
that referenced
this pull request
Mar 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add services (both public and internal) to add or remove user realms.