In-text Citation Popup Rendering Error

[chrisdaaz]

I'm using Quire 1.0.0-rc.0 on Windows 11.

I'm seeing some problems with rendering the in-text citation pop-ups. It seems that the text within the class="quire-citation__content" element is not ending up in the proper <span> element and is instead rendering directly on the page.

The short or id of the citation will be linked in the rendered text, but there won't be any text in the popup.

HTML Result with popupStyle: icon:

no click

click

HTML Result with popupStyle: text:

no click

click

Markdown:

By situating Egyptian burial practices within the social setting of the interactions between living descendants and deceased ancestors, it may become easier to appreciate the central importance of the ancestor cult in ancient Egyptian society (E.g., {% cite 'Nyord 2018' %}, {% cite 'Weiss 2022' %}).

YAML:

entries:

  - id: "Nyord 2018"
    full: >
      Nyord, Rune. 2018. “'Taking ancient Egyptian mortuary religion seriously': Why would we, and how could we?” *Journal of Ancient Egyptian Interconnections* 17: 73-87.

  - id: "Weiss 2022"
    full: >
      Weiss, Lara. 2012. *The Walking Dead at Saqqara: Strategies of Social and Religious Interaction in Practice*. Berlin and Boston: De Gruyter.

Do you see any issues with my Markdown or YAML content? Thanks!

[geealbers]

HI @chrisdaaz, the issue stems from the YAML formatting you're using, and is the same for Window and macOS. The > character indicates block-level content to follow and this is being rendered as a <p>, when it actually needs to be interpreted as a string and rendered as a <span> (since the citations will typically be made within block elements, and so can't be block elements themselves).

If you format the YAML like this, it should render correctly for you:

entries:

  - id: "Nyord 2018"
    full: "Nyord, Rune. 2018. “'Taking ancient Egyptian mortuary religion seriously': Why would we, and how could we?” *Journal of Ancient Egyptian Interconnections* 17: 73-87."

  - id: "Weiss 2022"
    full: "Weiss, Lara. 2012. *The Walking Dead at Saqqara: Strategies of Social and Religious Interaction in Practice*. Berlin and Boston: De Gruyter."

Simply removing the > character and maintaining the line breaks and indenting should also work, as long as the strings are quoted in order to avoid the colons in the references being interpreted as YAML characters:

entries:

  - id: "Nyord 2018"
    full: 
      "Nyord, Rune. 2018. “'Taking ancient Egyptian mortuary religion seriously': Why would we, and how could we?” *Journal of Ancient Egyptian Interconnections* 17: 73-87."

  - id: "Weiss 2022"
    full: 
      "Weiss, Lara. 2012. *The Walking Dead at Saqqara: Strategies of Social and Religious Interaction in Practice*. Berlin and Boston: De Gruyter."

I did some research to see if perhaps Quire's interpretation of the > character (and the same would go for the |) is incorrect, but from what I can tell, the character does specify that the content is a block element, and so Quire is rendering it as expected. Let us know though if we should be reexamining this.

[chrisdaaz]

Aha! Thanks @geealbers! It's been a minute, but I could have sworn using the | or > character was my way of getting around the problem of citation strings containing both single and double quotes breaking the YAML parser in the past.

For example, that full citation for "Nyord 2018" above will not work with quote, pipe (|), or > characters, but it will work if you add a minus (-) at the end so that new lines or empty lines are stripped from the end of the string. I'm guessing these new lines were creating the <p> elements.

Formatting my YAML like this (|-):

- id: "Nyord 2018"
  full: |-
      Nyord, Rune. 2018. "'Taking ancient Egyptian mortuary religion seriously': Why would we, and how could we?" *Journal of Ancient Egyptian Interconnections* 17: 73-87.'

or like this (>-):

- id: "Nyord 2018"
  full: >-
      Nyord, Rune. 2018. "'Taking ancient Egyptian mortuary religion seriously': Why would we, and how could we?" *Journal of Ancient Egyptian Interconnections* 17: 73-87.'

Fixes the problem.