Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate compare and coverage into easy to use functions #10

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

MaximMoinat
Copy link

Changes:

  • Three exported utility functions: plotCompareDqdResults, tableCompareDqdResults, plotConceptCoverage
  • Documentation generated for each function
  • Writing output is optional for all three
  • Four labels in compare plot, distinguishing tests that have changed failed status (FAIL->PASS, PASS->FAIL, FAIL->FAIL,PASS->PASS) @egarcialara: I choose new colours that I think are appropriate, please change if you think otherwise!

Copy link

@egarcialara egarcialara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change.

Looks great :D

R/util.R Outdated Show resolved Hide resolved
R/util.R Outdated Show resolved Hide resolved
Maxim Moinat and others added 2 commits September 15, 2021 12:50
Co-authored-by: Elena <35764654+egarcialara@users.noreply.github.com>
Co-authored-by: Elena <35764654+egarcialara@users.noreply.github.com>
@MaximMoinat MaximMoinat merged commit 19ec738 into utilities Sep 15, 2021
@MaximMoinat MaximMoinat deleted the utilities-incorporate branch September 15, 2021 10:51
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants