Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping coverage #2

Merged
merged 4 commits into from
May 6, 2021
Merged

Mapping coverage #2

merged 4 commits into from
May 6, 2021

Conversation

MaximMoinat
Copy link

This generates an overview of concept mapping coverage directly from DQD results. For the main OMOP domains it takes the percentage of unique terms mapped and the percentage of all records with a mapping (dqd checks sourceValueCompleteness and standardConceptRecordCompleteness respectively).

image

@egarcialara We can start collecting your other DQD 'utility scripts' in the same way. And please take a look whether my code can be improved!

@egarcialara
Copy link

Awesome! I've just run it for ABUCASIS and it's really nice haha

A couple of things:

  • Perhaps it could be added the absolute number of unique terms and records for each domain/unit, in order to have a more complete figure?
  • How final are the scripts? Depending on that, we can think of a directory to save the figures and tables, a common theme/background, and increase the fontsize for the domain/unit.
  • [just for myself] where could I find the "fig 6 in EHDEN DoA"?

@MaximMoinat
Copy link
Author

  • Perhaps it could be added the absolute number of unique terms and records for each domain/unit, in order to have a more complete figure?

I gave it a try, but it gets messy. This data can be found in the outputted table if someone wants to go in depth.

  • How final are the scripts? Depending on that, we can think of a directory to save the figures and tables, a common theme/background, and increase the fontsize for the domain/unit.

Might be nice indeed to apply same style to all new plots (also your dqd compare). Let's come back to it later, when we integrate these in the shiny app.

just in case, if you want to make it general you can use separate: ... [prob not use for observation/observation_period, but here I leave it]

Nice! It actually also causes issues with e.g. CARE_SITE. But I liked the idea of generalising, I made it into the following mutate: domain = gsub("_(OCC\\w+|EXP\\w+|PLAN.+)$", "", CDM_TABLE_NAME),

@MaximMoinat MaximMoinat merged commit 183c522 into utilities May 6, 2021
@MaximMoinat MaximMoinat deleted the coverage_stats branch September 15, 2021 10:53
MaximMoinat pushed a commit that referenced this pull request Apr 13, 2022
Squashed commit of the following:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants