Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Make code lens work #2

Closed
JanKoehnlein opened this issue Nov 29, 2017 · 1 comment
Closed

Make code lens work #2

JanKoehnlein opened this issue Nov 29, 2017 · 1 comment

Comments

@JanKoehnlein
Copy link
Member

Code lens works fine apart from opening the references:

The server composes a set of arguments of type URI, Position and Location[] for the editor.action.showReferences command (in goReferencesCodelens#resolveCodeLens). These are sent to the client, as such converted to plain JSON objects. The client, when trying to execute the command, validates the args to be instance of URI, IPosition and Array, which fails as they are plain JSON objects.

One solution could be to register a separate command in the theia-go-extension that is called instead and does the conversion.

JanKoehnlein added a commit that referenced this issue Nov 30, 2017
@JanKoehnlein
Copy link
Member Author

Fixed with 3287c4f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant