Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Try to find a solution for selection sensitive commands #3

Closed
JanKoehnlein opened this issue Nov 29, 2017 · 3 comments
Closed

Try to find a solution for selection sensitive commands #3

JanKoehnlein opened this issue Nov 29, 2017 · 3 comments

Comments

@JanKoehnlein
Copy link
Member

On the LS, we don't have selection. Would be great if the client sent the selection as an argument with the commands that need it. A wrapper command on the client could be helpful.
@svenefftinge
Copy link

We could add a selectionChanged notification to the protocol

@JanKoehnlein
Copy link
Member Author

JanKoehnlein commented Nov 30, 2017 •
edited
Loading

As far as I can see, these are mainly new commands, so for Theia we could solve that by adding the selection as a command argument in the calling Theia extension. Feels a bit less invasive and less verbose than forwarding each new selection to the LS.

JanKoehnlein added a commit to theia-ide/theia-go-extension that referenced this issue Dec 1, 2017
@JanKoehnlein
Send current document's uri and selection as args to all external com…
dc09e64 
…mands

theia-ide/go-language-server#3
JanKoehnlein added a commit that referenced this issue Dec 1, 2017
@JanKoehnlein
GH-3 enable commands that depend on editor selection
2b972eb
@JanKoehnlein
Copy link
Member Author

2b972eb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svenefftinge @JanKoehnlein