Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-149: Added name support for revision statements. #150

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Nov 12, 2018

So they will show up in the Outline.
The name will be the revision date.

Closes: #149.

Signed-off-by: Akos Kitta kittaakos@typefox.io


For reviewers:

Model:

module abc {
    yang-version 1.1;
    namespace abc;
    prefix a;
    revision 2018-10-10 {
          a:version 4;
          a:release 5;
          a:correction 6;
    }
    revision 2018-09-10 {
          a:version 1;
          a:release 2;
          a:correction 3;
    }
    extension version {
        argument value;
    }
    extension release {
        argument value;
    }
    extension correction {
        argument value;
    }
}

Before the change:

screen shot 2018-11-12 at 10 51 17

After the change:

screen shot 2018-11-12 at 13 50 58

So they will show up in the `Outline`.
The name will be the revision date.

Closes: #149.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kittaakos kittaakos merged commit 2aca17f into master Nov 13, 2018
@kittaakos kittaakos deleted the GH-149 branch November 13, 2018 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yang Outline Issue
2 participants