Conversation
Hi @antschum, It looks like this pull-request is has been made against the theislab/augurpy You do not need to close this PR, you can change the target branch to Thanks again for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'm not the biggest fan of the term "scorer" because we just set "scores" aka a "score". Might just be me though :)
But besides that just a few minor comments again.
Is scoring better? So because I did have to take the scores and turn them into scorings/scorers so that they take estimators and y values instead of only comparing predicted and true values. |
I see. Yeah no worries, you can keep it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor again. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Implementation of cross validation (which will be used to calculate the overall AUC)
Updated load function to transfer categorical data into dummy variables (so that sklearn random forest classifier and logistic regression classifier can fit the data)
Fixed small errors.