Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Feature/crossvalidation #32

Merged
merged 10 commits into from Dec 14, 2021
Merged

Feature/crossvalidation #32

merged 10 commits into from Dec 14, 2021

Conversation

antschum
Copy link
Collaborator

Implementation of cross validation (which will be used to calculate the overall AUC)
Updated load function to transfer categorical data into dummy variables (so that sklearn random forest classifier and logistic regression classifier can fit the data)
Fixed small errors.

@github-actions
Copy link

Hi @antschum,

It looks like this pull-request is has been made against the theislab/augurpy master or main branch.
The master/main branch should always contain code from the latest release.
Because of this, PRs to master/main are only allowed if they come from any theislab/augurpy release or patch branch.

You do not need to close this PR, you can change the target branch to development by clicking the "Edit" button at the top of this page.

Thanks again for your contribution!

@antschum antschum changed the base branch from main to development December 13, 2021 13:34
@github-actions github-actions bot added the enhancement New feature or request label Dec 13, 2021
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'm not the biggest fan of the term "scorer" because we just set "scores" aka a "score". Might just be me though :)

But besides that just a few minor comments again.

tests/test_cv.py Show resolved Hide resolved
tests/test_cv.py Outdated Show resolved Hide resolved
@antschum
Copy link
Collaborator Author

In general I'm not the biggest fan of the term "scorer" because we just set "scores" aka a "score". Might just be me though :)

But besides that just a few minor comments again.

Is scoring better? So because I did have to take the scores and turn them into scorings/scorers so that they take estimators and y values instead of only comparing predicted and true values.

@Zethson
Copy link
Member

Zethson commented Dec 14, 2021

In general I'm not the biggest fan of the term "scorer" because we just set "scores" aka a "score". Might just be me though :)
But besides that just a few minor comments again.

Is scoring better? So because I did have to take the scores and turn them into scorings/scorers so that they take estimators and y values instead of only comparing predicted and true values.

I see. Yeah no worries, you can keep it :)

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor again. Thanks!

pyproject.toml Show resolved Hide resolved
tests/test_cv.py Outdated Show resolved Hide resolved
@antschum antschum mentioned this pull request Dec 14, 2021
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@Zethson Zethson merged commit 2764ff6 into development Dec 14, 2021
@Zethson Zethson deleted the feature/crossvalidation branch December 14, 2021 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants