You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
remove some redundancies (esp. w.r.t. to indexing)
document/simplify indexing behavior
fix KeyError when wrong lineage is passed - e.g. KeyError: "Invalid lineage name: `Notoch`. Valid names are: `['Early Blastomeres_1', 'Early Blastomeres_2', 'Notochord']`." when passing Notochord2 and Notochord is present
The text was updated successfully, but these errors were encountered:
@michalk8, as we had discussed before (last year?), I recommend against creating a custom on-disk schema for the Lineage class if you can avoid it.
It seems like casting things that have been read as arrays to Lineage objects works fine at the moment
If cellrank hasn't been imported, other libraries will not be able to read in AnnData's containing Lineages
Libraries from other languages will also not be read these in.
From my perspective, it seems like you'd be giving up a lot of interoperability for something that works as is. In terms of maintenance, on disk formats kinda require you support them forever. APIs can change with a version bump.
TODOs:
[ ] consider not subclassingnumpy.ndarray
(related to Lineage class and consolidation of cluster representations with scanpy #759 )KeyError: "Invalid lineage name: `Notoch`. Valid names are: `['Early Blastomeres_1', 'Early Blastomeres_2', 'Notochord']`."
when passingNotochord2
andNotochord
is presentThe text was updated successfully, but these errors were encountered: