Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lineage class serialization #860

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Conversation

michalk8
Copy link
Collaborator

IMPORTANT: Please search among the Pull requests before creating one.

Description

Fix writing :class:cellrank.tl.Lineage when saving :class:anndata.AnnData.

How has this been tested?

Will be tested in the follow-up PR.

Closes

partially addresses #777

@michalk8 michalk8 added the bugfix PR fixes a bug label Apr 21, 2022
@michalk8 michalk8 self-assigned this Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #860 (84fc4ea) into master (ac6efec) will increase coverage by 0.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   82.12%   82.14%   +0.01%     
==========================================
  Files          70       70              
  Lines        9282     9290       +8     
  Branches     1878     1878              
==========================================
+ Hits         7623     7631       +8     
  Misses       1076     1076              
  Partials      583      583              
Impacted Files Coverage Δ
cellrank/tl/estimators/terminal_states/_gpcca.py 80.00% <83.33%> (-0.04%) ⬇️
cellrank/tl/_lineage.py 84.18% <100.00%> (+0.22%) ⬆️

@michalk8 michalk8 changed the title Fix/refactor lineage class Fix lineage class serialization Apr 21, 2022
@michalk8 michalk8 merged commit 3d0ae2f into master Apr 21, 2022
@michalk8 michalk8 deleted the fix/refactor-lineage-class branch April 21, 2022 15:52
michalk8 added a commit that referenced this pull request Apr 21, 2022
@Marius1311
Copy link
Collaborator

Thanks Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants