Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent requrement #13

Closed
moinfar opened this issue Jun 10, 2018 · 3 comments
Closed

inconsistent requrement #13

moinfar opened this issue Jun 10, 2018 · 3 comments

Comments

@moinfar
Copy link

moinfar commented Jun 10, 2018

Hi,

Recent updates on scanpy made this package inconsistent with it.
If you use scanpy>=1.1a (given an arbitrary input), on saving stage you will face:

  File "/usr/local/lib/python3.5/site-packages/DCA/train.py", line 168, in train_with_args
    net.predict(adata, predict_columns)
  File "/usr/local/lib/python3.5/site-packages/DCA/network.py", line 404, in predict
    res = super().predict(adata, colnames=colnames, **kwargs)
  File "/usr/local/lib/python3.5/site-packages/DCA/network.py", line 220, in predict
    sc.write('output', adata)
  File "/usr/local/lib/python3.5/site-packages/scanpy/readwrite.py", line 159, in write
    if is_valid_filename(filename):
  File "/usr/local/lib/python3.5/site-packages/scanpy/readwrite.py", line 510, in is_valid_filename
    elif ext[-1][1:] in avail_exts:
IndexError: list index out of range

The source of problem is this commit of scanpy.

Regards :D

@gokceneraslan
Copy link
Collaborator

Thanks a lot for the bug report. It's actually the next commit that broke this. I informed Alex there, thanks again!

@moinfar
Copy link
Author

moinfar commented Jun 17, 2018

You're Welcome ;-)

@gokceneraslan
Copy link
Collaborator

Fixed in 0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants