Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_fgw_problem.py: test_prepare_costs alpha given to prepare #699

Closed
selmanozleyen opened this issue May 27, 2024 · 1 comment
Closed
Labels
conceptual Conceptual discussions low-prio Low priority issue.

Comments

@selmanozleyen
Copy link
Collaborator

Here alpha shouldn't be given to prepare otherwise it will throw error after #696. So I removed it in that PR. Or do we want another kind of behavior? Note that this alpha also doesn't go to solve method its just ignored.

def test_prepare_costs(self, adata_time: AnnData, cost_str: str, cost_inst: Any, cost_kwargs: CostKwargs_t):
problem = FGWProblem(adata=adata_time)
problem = problem.prepare(
key="time",
policy="sequential",
joint_attr="X_pca",
alpha=0.5,
x_attr="X_pca",
y_attr="X_pca",
cost=cost_str,
cost_kwargs=cost_kwargs,
)

@selmanozleyen selmanozleyen added low-prio Low priority issue. conceptual Conceptual discussions labels May 27, 2024
@selmanozleyen
Copy link
Collaborator Author

closed with #696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptual Conceptual discussions low-prio Low priority issue.
Projects
None yet
Development

No branches or pull requests

1 participant