DIALOGUE extensions and plots #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: pair plot currently not working
plotting functionality for dialogue now works!
Functions for testing whether dialogue scores correlate with .obs variables, collating MCP genes calculated using multilevel modeling, and an alternative faster gene scoring function
Bug fixes to get_mlm_mcp_genes
for more information, see https://pre-commit.ci
Zethson
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Thank you so much for your contributions! That's a lot of work. I'll go through ASAP and fix a few things. General comment: The design of your docstrings is a bit off. I'd encourage you to look at the rest of the code to get a feeling for the design.
Thank you!!
pertpy/plot/_dialogue.py
Outdated
| with a value for split_key not in split_which are removed from the plot. | ||
|
|
||
| Args: | ||
| adata (AnnData): Annotated data object. |
There was a problem hiding this comment.
Please don't add typehints in any arguments. vscode or something probably autogenerates them, but we don't need them because a sphinx extension gets them from the function definition. Having them twice just adds maintenance burden.
Signed-off-by: zethson <lukas.heumos@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Still no tests for Dialogue. @Zethson will update documentation.
Description of changes
New functions for Dialogue output analysis, including split violin and pair plots.
Technical details
Newer version of Seaborn needed for pairplot
Additional context