Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VELOVI preprocess methods #1228

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinkim0
Copy link

  • adds min_max_scale, filter_genes_r2, and velovi_preprocess_recipe to preprocessing.utils

to-do:

  • add tests
  • add get_permutation_scores

@martinkim0
Copy link
Author

martinkim0 commented Mar 27, 2024

Hi @WeilerP, this is the PR based on our discussion in scverse/scvi-tools#2611. I wanted to get your thoughts on the following:

  • where should I add get_permutation_scores?
  • under what section in api.rst should velovi_preprocess_recipe be in?

cc @adamgayoso

@martinkim0 martinkim0 marked this pull request as draft March 27, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant