Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using general purpose bit 3 when possible #13

Closed
thejoshwolfe opened this issue Mar 20, 2015 · 4 comments
Closed

Avoid using general purpose bit 3 when possible #13

thejoshwolfe opened this issue Mar 20, 2015 · 4 comments

Comments

@thejoshwolfe
Copy link
Owner

7-zip 9.20 seems to not support general purpose bit 3. It wouldn't be too difficult to avoid relying on general purpose bit 3 sometimes, for example when a file is added with addBuffer().

Enhancing addBuffer() to avoid general purpose bit 3 will enable users to have compatibility with 7-zip 9.20 by buffering their files in ram and using addBuffer() exclusively.

@joaomoreno
Copy link
Contributor

Great stuff! 👍

@joaomoreno
Copy link
Contributor

@thejoshwolfe

Mac's Archive Utility requires File Descriptors to include the optional signature, so yazl includes the optional file descriptor signature.

It appears that it's not possible to create an archive with yazl that can be extracted by both Mac's Archive Utility and 7-Zip 9.20. Is this correct?

How could we make this work for both applications?

@andrewrk
Copy link
Collaborator

If you use the addBuffer API, it avoids using general purpose bit 3, which works around the bug in 7-Zip 9.20. This is unrelated to the optional file descriptor signature and unrelated to Mac's Archive Utility.

@joaomoreno
Copy link
Contributor

Then unfortunately there might've been an oversight on the latest release. I've created #14 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants