Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIPA-2964] Adds Ingress #269

Merged
merged 2 commits into from
Aug 26, 2022
Merged

[SHIPA-2964] Adds Ingress #269

merged 2 commits into from
Aug 26, 2022

Conversation

stinkyfingers
Copy link
Contributor

@stinkyfingers stinkyfingers commented Jul 8, 2022

Description

  • adds a configmap watcher that watches for changes to configmap that stores ingress controller data
  • adds GetIngress() call in app reconciler, which set's an app's ingress controller from the configmap values if the app has empty ingress values
  • adds ingress set and ingress get to CLI
  • unit tests
  • updates acceptance (cli) tests

Fixes # 2964

TEST:
make ketch
Set up make generate manifests uninstall && make install
./bin/ketch ingress set -c nginx -s 127.0.0.1 -t nginx
./bin/ketch ingress get
./bin/ketch app deploy myapp -i gcr.io/shipa-ci/sample-go-app -n default
k get app myapp -oyaml <- see ingress fields

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

set ingress type during tests; return workflow to original state

remove redundant gh steps

correct ns for ingress service
@stinkyfingers stinkyfingers merged commit 5cabb17 into main Aug 26, 2022
@stinkyfingers stinkyfingers deleted the shipa-2964 branch August 26, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants