Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.0 #235

Merged
merged 18 commits into from
Mar 5, 2022
Merged

v0.12.0 #235

merged 18 commits into from
Mar 5, 2022

Conversation

thekevinscott
Copy link
Owner

@thekevinscott thekevinscott commented Mar 3, 2022

#9

Enable cancellation of an inflight upscale request

* Refactor predict to be a generator function
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #235 (3c0bba5) into main (abd7a18) will decrease coverage by 0.17%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   88.82%   88.64%   -0.18%     
==========================================
  Files           8        9       +1     
  Lines         331      405      +74     
  Branches       50       63      +13     
==========================================
+ Hits          294      359      +65     
- Misses         37       46       +9     
Impacted Files Coverage Δ
packages/upscalerjs/src/upscale.ts 92.43% <88.00%> (-2.27%) ⬇️
packages/upscalerjs/src/upscaler.ts 84.61% <100.00%> (ø)
packages/upscalerjs/src/utils.ts 100.00% <100.00%> (+3.57%) ⬆️
packages/upscalerjs/src/warmup.ts 100.00% <0.00%> (ø)
packages/upscalerjs/src/image.node.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd7a18...3c0bba5. Read the comment docs.

* Update version script to also update dependencies
* Migrate progress test to upscale

* Add integration test for cancel
* Refactor predict function

* Insist on parameters for sub upscale functions
…eturn values (#242)

* Rearrange upscale functions to be typed better and add a memory leak test
* Set up a generator wrap function

* Add test for wrapGenerator function

* Strengthen tests around generator wrap

* Remove console logs

* Add test to cover console warn

* Add coverage to isAborted method
* Add unit test for memory allocation in predict function
* Bump to latest version and add babelrc

* Migrate examples to use esbuild instead of parcel

* Remove yarnrc from repo

* Ignore yarnrc
* Add abort signal to enable cancellation

* Initial commit for cancel example

* Merge upstream

* Implement cancel example
* Add a top level abort

* Add an integration test for cancel

* Update documentation

* Fix deepsource issue
@thekevinscott thekevinscott merged commit 073f991 into main Mar 5, 2022
@thekevinscott thekevinscott deleted the ks/v0.12.0 branch March 5, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant