LPS-82787 portal-search-web: Use button for links without an href #68

thektan · 2019-10-04T23:26:25Z

http://issues.liferay.com/browse/LPS-82787

…checkbox markup

… main.scss

…e overridden This also makes a stronger tie with the default clay `custom-control-label` css class that we are attempting to style on top of.

liferay-continuous-integration · 2019-10-04T23:26:28Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

thektan · 2019-10-04T23:29:48Z

ci:test:sf

thektan · 2019-10-04T23:30:01Z

ci:test:search

liferay-continuous-integration · 2019-10-04T23:33:05Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 6 seconds 15 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a0efb8c930d3246f80cc349dba4f0c85be8a4768

Sender Branch:

Branch Name: pr-66
Branch GIT ID: 7919dae607171b86374e34c5e61539de7d465708

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2019-10-05T00:37:53Z

❌ ci:test:search - 25 out of 32 jobs passed in 1 hour 7 minutes 33 seconds 790 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 67313d14e94aa2f0d531b4e11658e03a2a65aed7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 020f12be3b7f68e4dcb3356fbd50440b139473fd

25 out of 32 jobs PASSED

7 Failed Jobs:

25 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8

Job Results:

7 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=7,label_exp=!master #325048

Please fix semantic versioning on thektan/pr-66

     [exec] 
     [exec] > Task :apps:dynamic-data-lists:dynamic-data-lists-web:baseline SKIPPED
     [exec] > Task :apps:dynamic-data-lists:dynamic-data-lists-web:syncVersions
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:portal-search:portal-search-web:compileJSP
     [exec] 
     [exec] > Task :apps:portal-search:portal-search-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:portal-search:portal-search-web:jar
     [exec] > Task :apps:portal-search:portal-search-web:baseline SKIPPED
     [exec] > Task :apps:portal-search:portal-search-web:syncVersions
     [exec] 
     [exec] > Task :apps:portal-search:portal-search-admin-web:packageRunBuild
     [exec] Successfully compiled 3 files with Babel.
     [exec] Bundling took 553ms
     [exec] Done in 6.63s.
     [exec] 
     [exec] > Task :apps:portal-search:portal-search-admin-web:classes
     [exec] 
     [exec] > Task :apps:portal-search:portal-search-admin-web:generateJSPJava
     [exec] Compiling JSP files of project ':apps:portal-search:portal-search-admin-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.17/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
     [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/portal-search/portal-search-admin-web/build/jspc/org/apache/jsp/index_005factions_jsp.java uses or overrides a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] 
     [exec] > Task :apps:portal-search:portal-search-admin-web:compileJSP
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:portal-remote:portal-remote-cors-api:baseline'.
     [exec] > Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.portal.remote.cors.api-2.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.portal.remote.cors.api/1.0.8/59a7ef00a5a735f0cb0df3000be03b9943b9b168/com.liferay.portal.remote.cors.api-1.0.8.jar

AXIS_VARIABLE=0,label_exp=!master #325048

Please fix semantic versioning on thektan/pr-66

     [exec] 
     [exec] > Task :apps:portal-security-wedeploy-auth:portal-security-wedeploy-auth-web:compileJava
     [exec] 
     [exec] > Task :apps:portal-security-wedeploy-auth:portal-security-wedeploy-auth-web:copyLibs SKIPPED
     [exec] > Task :apps:portal-security-wedeploy-auth:portal-security-wedeploy-auth-web:classes
     [exec] 
     [exec] > Task :apps:unit-converter:unit-converter-web:compileJSP
     [exec] 
     [exec] > Task :apps:unit-converter:unit-converter-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:unit-converter:unit-converter-web:jar
     [exec] > Task :apps:unit-converter:unit-converter-web:baseline SKIPPED
     [exec] > Task :apps:unit-converter:unit-converter-web:syncVersions
     [exec] > Task :apps:image-uploader:image-uploader-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:image-uploader:image-uploader-web:jar
     [exec] > Task :apps:image-uploader:image-uploader-web:baseline SKIPPED
     [exec] > Task :apps:image-uploader:image-uploader-web:syncVersions
     [exec] 
     [exec] > Task :apps:portal-security-wedeploy-auth:portal-security-wedeploy-auth-web:generateJSPJava
     [exec] Compiling JSP files of project ':apps:portal-security-wedeploy-auth:portal-security-wedeploy-auth-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.17/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/portal-security-wedeploy-auth/portal-security-wedeploy-auth-web/build/jspc/org/apache/jsp/wedeploy_005fauth_005fadmin/view_jsp.java uses unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:portal-security-wedeploy-auth:portal-security-wedeploy-auth-web:compileJSP
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:polls:polls-api:baseline'.
     [exec] > Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.polls.api-7.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.polls.api/6.1.0/c2e15132c91707af658c0263ea264459d5fcac3f/com.liferay.polls.api-6.1.0.jar

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/10
Job Results:
20 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #196847
  1. LocalFile.Search#NavigateToSearchResultsViaURL - Poshi Report - Poshi Summary - Console Output
2. AXIS_VARIABLE=2,label_exp=!master #196847
  1. LocalFile.Search#SearchUsingCustomFacet - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/14
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #345038
  1. LocalFile.Search#SearchDocumentsAndMediaDocument - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/15
Job Results:
4 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=0,label_exp=!master #302218
  1. LocalFile.Search#AssertBasicFacetSelection - Poshi Report - Poshi Summary - Console Output
  2. LocalFile.Search#SearchWithModifiedFacet - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/6
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #327263
  1. LocalFile.Search#ViewFacetPersistence - Poshi Report - Poshi Summary - Console Output
...

For upstream results, click here.

joshchong · 2019-10-10T22:58:23Z

ci:test:bundle

liferay-continuous-integration · 2019-10-10T23:38:57Z

✔️ ci:test:bundle - 1 out of 1 jobs passed in 40 minutes 13 seconds 833 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d3be318e1075f0943b668a036605358c26c3eab9

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 9abff772ffeb60a7160eae44aedcfcbc7b3a3f6d

1 out of 1 jobs PASSED

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

thektan · 2019-10-23T17:51:49Z

Submitted: brianchandotcom#79765

LPS-112856 [Test] Integration Test: "Boost-A-Clause"

oliv-yu and others added 4 commits October 4, 2019 14:53

LPS-82787 portal-search-web: Search Portlet Facets should use custom …

e48e80d

…checkbox markup

LPS-82787 portal-search-web: Apply CSS styling for search portlets in…

bf58a2e

… main.scss

LPS-82787 portal-search-web: More specific css to make sure styles ar…

7c1c533

…e overridden This also makes a stronger tie with the default clay `custom-control-label` css class that we are attempting to style on top of.

LPS-82787 portal-search-web: Use button for links without an href

7919dae

thektan mentioned this pull request Oct 4, 2019

LPS-82787 Custom checkboxes #66

Closed

liferay-continuous-integration added ci:test:search - pending ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Oct 4, 2019

liferay-continuous-integration added ci:test:search - failure and removed ci:test:search - pending labels Oct 5, 2019

liferay-continuous-integration added ci:test:bundle - pending ci:test:bundle - success and removed ci:test:bundle - pending labels Oct 10, 2019

thektan closed this Oct 23, 2019

thektan deleted the pr-66 branch February 7, 2020 17:56

thektan pushed a commit that referenced this pull request Jan 8, 2021

Merge pull request #68 from joshuacords/LPS-112856_Search_Blueprints

ac60287

LPS-112856 [Test] Integration Test: "Boost-A-Clause"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-82787 portal-search-web: Use button for links without an href #68

LPS-82787 portal-search-web: Use button for links without an href #68

thektan commented Oct 4, 2019

liferay-continuous-integration commented Oct 4, 2019

thektan commented Oct 4, 2019

thektan commented Oct 4, 2019

liferay-continuous-integration commented Oct 4, 2019

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 5, 2019

Base Branch:

Copied in Private Modules Branch:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/10

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/14

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/15

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/6

Job Results:

For upstream results, click here.

joshchong commented Oct 10, 2019

liferay-continuous-integration commented Oct 10, 2019

Base Branch:

Copied in Private Modules Branch:

For more details click here.

thektan commented Oct 23, 2019

LPS-82787 portal-search-web: Use button for links without an href #68

LPS-82787 portal-search-web: Use button for links without an href #68

Conversation

thektan commented Oct 4, 2019

liferay-continuous-integration commented Oct 4, 2019

thektan commented Oct 4, 2019

thektan commented Oct 4, 2019

liferay-continuous-integration commented Oct 4, 2019

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 6 seconds 15 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 5, 2019

❌ ci:test:search - 25 out of 32 jobs passed in 1 hour 7 minutes 33 seconds 790 ms

Base Branch:

Copied in Private Modules Branch:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/10

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/14

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/15

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/6

Job Results:

For upstream results, click here.

joshchong commented Oct 10, 2019

liferay-continuous-integration commented Oct 10, 2019

✔️ ci:test:bundle - 1 out of 1 jobs passed in 40 minutes 13 seconds 833 ms

Base Branch:

Copied in Private Modules Branch:

For more details click here.

Test bundle downloads:

thektan commented Oct 23, 2019