Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameter to allow overriding the fqdn for new cluster #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

burmanm
Copy link
Collaborator

@burmanm burmanm commented Mar 19, 2021

If restoring to a new cluster, we need to fetch the backup from an old name (instead of the new cluster name / podname).

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1407
┆priority: Medium

@burmanm
Copy link
Collaborator Author

burmanm commented Mar 31, 2021

15 lines max per function in SonarCloud settings? And why does it complain duplication from the project for PRs that do not modify the files?

@adejanovski
Copy link
Contributor

15 lines max per function in SonarCloud settings?

It's not complaining about the number of lines actually :) Sonar computes a cognitive complexity for methods/functions, and has a default threshold at 15. If we're over this, it means there are too many things happening in the same function, making it hard to understand. It should then be broken up into smaller functions to help making it readable.

And why does it complain duplication from the project for PRs that do not modify the files?

You're right, it shouldn't be complaining here so let's ignore this. You clearly didn't touch any of the files that are reported.

@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
19.4% 19.4% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants