Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable build for Debian/Bullseye #529

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rtib
Copy link
Contributor

@rtib rtib commented Sep 29, 2022

This change is needed to enable packaging for Debian/Bullseye.

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1810
┆priority: Medium

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@UgurcanAkkok
Copy link

Hi, any progress/update here?

@rtib
Copy link
Contributor Author

rtib commented Sep 20, 2023

Pinging @adejanovski . How are the chances to get that merged and packages for Debian released? Soon, I'd also bring that forward to Bookworm.

@rzvoncek rzvoncek added ready Issues in the state 'ready' refactoring and removed zh:In-Progress labels Sep 20, 2023
@rzvoncek rzvoncek self-assigned this Sep 20, 2023
@rzvoncek
Copy link
Contributor

Hi @rtib! Yes, let's move forward with this. Could you please fix the conflict (it seems fairly straightforward)? If the builds pass, I think we can go ahead and merge.

@rtib
Copy link
Contributor Author

rtib commented Sep 28, 2023

Have rebased it.

debian/rules Outdated
@@ -30,7 +30,7 @@ export DH_VIRTUALENV_INSTALL_ROOT = /usr/share
override_dh_virtualenv:
dh_virtualenv \
--extra-pip-arg "--no-cache-dir" \
--python /usr/bin/python3 --preinstall=setuptools==40.3.0 --preinstall=pip==21.3.1 --preinstall=wheel --builtin-venv
--python /usr/bin/python3 --preinstall=setuptools==52.0.0 --preinstall=pip==20.3.4 --preinstall=wheel==0.34.2 --builtin-venv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't downgrade pip here. Only setuptools needs to be upgraded for this to work on debian 11.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. It could also run even without pinned version at least for focal and bullseye. I'm affraid I did this to get it work for buster, but that's over the edge now.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.9% 2.9% Duplication

@rtib
Copy link
Contributor Author

rtib commented Oct 3, 2023

Build is failing at the install package step due to the fact, that the package is built for Debian and installed on Ubuntu. Unfortunately, there is no public actions runner with Debian supported by GH. Either we need a custom GHA runner with Debian-11 or we need to move this test into a container.

@Skunnyk
Copy link
Contributor

Skunnyk commented Oct 11, 2023

Please note that since medusa 0.16, debian 10 (with python 3.7.3) won't work with s3_compatible storage because of this botocore3/python/openssl issue : boto/botocore#2702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Issues in the state 'ready' refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants