-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable build for Debian/Bullseye #529
base: master
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed!
|
No linked issues found. Please add the corresponding issues in the pull request description. |
b3e6bb2
to
e98c353
Compare
Kudos, SonarCloud Quality Gate passed!
|
Hi, any progress/update here? |
Pinging @adejanovski . How are the chances to get that merged and packages for Debian released? Soon, I'd also bring that forward to Bookworm. |
Hi @rtib! Yes, let's move forward with this. Could you please fix the conflict (it seems fairly straightforward)? If the builds pass, I think we can go ahead and merge. |
e98c353
to
df17456
Compare
Have rebased it. |
debian/rules
Outdated
@@ -30,7 +30,7 @@ export DH_VIRTUALENV_INSTALL_ROOT = /usr/share | |||
override_dh_virtualenv: | |||
dh_virtualenv \ | |||
--extra-pip-arg "--no-cache-dir" \ | |||
--python /usr/bin/python3 --preinstall=setuptools==40.3.0 --preinstall=pip==21.3.1 --preinstall=wheel --builtin-venv | |||
--python /usr/bin/python3 --preinstall=setuptools==52.0.0 --preinstall=pip==20.3.4 --preinstall=wheel==0.34.2 --builtin-venv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't downgrade pip
here. Only setuptools
needs to be upgraded for this to work on debian 11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. It could also run even without pinned version at least for focal and bullseye. I'm affraid I did this to get it work for buster, but that's over the edge now.
Kudos, SonarCloud Quality Gate passed!
|
Build is failing at the install package step due to the fact, that the package is built for Debian and installed on Ubuntu. Unfortunately, there is no public actions runner with Debian supported by GH. Either we need a custom GHA runner with Debian-11 or we need to move this test into a container. |
Please note that since medusa 0.16, debian 10 (with python 3.7.3) won't work with s3_compatible storage because of this botocore3/python/openssl issue : boto/botocore#2702 |
This change is needed to enable packaging for Debian/Bullseye.
┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1810
┆priority: Medium