testing expected size changes in cmd upload of awscli #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachanKaur
force-pushed
the
rachan553-expected-size
branch
2 times, most recently
from
433508a
to
b3cb56b
Compare
RachanKaur
force-pushed
the
rachan553-expected-size
branch
from
b3cb56b
to
2740447
Compare
RachanKaur
force-pushed
the
rachan553-expected-size
branch
from
071105b
to
2740447
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
==========================================
+ Coverage 80.56% 80.65% +0.09%
==========================================
Files 58 58
Lines 4558 4607 +49
Branches 678 740 +62
==========================================
+ Hits 3672 3716 +44
- Misses 860 864 +4
- Partials 26 27 +1
|
RachanKaur
force-pushed
the
rachan553-expected-size
branch
from
21eadac
to
48ad8ea
Compare
RachanKaur
force-pushed
the
rachan553-expected-size
branch
from
48ad8ea
to
3513c71
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
RachanKaur
added
ready-for-review
rzvoncek
approved these changes
Jul 21, 2023
adejanovski
pushed a commit
that referenced
this pull request
Sep 4, 2023
* testing expected size changes in cmd upload of awscli * unit tests added for awscli cp_upload and get file size functions * Unit tests added for code changes * unecessary code removed * removed 78GB comment * added config values for expected_size_threshold * --expected-size flag added for awscli
adejanovski
pushed a commit
that referenced
this pull request
Sep 4, 2023
* testing expected size changes in cmd upload of awscli * unit tests added for awscli cp_upload and get file size functions * Unit tests added for code changes * unecessary code removed * removed 78GB comment * added config values for expected_size_threshold * --expected-size flag added for awscli
adejanovski
pushed a commit
that referenced
this pull request
Sep 18, 2023
* testing expected size changes in cmd upload of awscli * unit tests added for awscli cp_upload and get file size functions * Unit tests added for code changes * unecessary code removed * removed 78GB comment * added config values for expected_size_threshold * --expected-size flag added for awscli
adejanovski
pushed a commit
that referenced
this pull request
Sep 19, 2023
* testing expected size changes in cmd upload of awscli * unit tests added for awscli cp_upload and get file size functions * Unit tests added for code changes * unecessary code removed * removed 78GB comment * added config values for expected_size_threshold * --expected-size flag added for awscli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #553
This PR adds --expected-size to cmd command for Aws Cli for uploading a file.