Skip 0-sized blobs when listing storage. Fixes #595. #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzvoncek
force-pushed
the
radovan/595-hiearchical-azure
branch
2 times, most recently
from
c84fdea
to
14ca1dc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
==========================================
- Coverage 80.56% 79.35% -1.21%
==========================================
Files 58 58
Lines 4558 4601 +43
Branches 678 688 +10
==========================================
- Hits 3672 3651 -21
- Misses 860 919 +59
- Partials 26 31 +5
|
rzvoncek
force-pushed
the
radovan/595-hiearchical-azure
branch
from
14ca1dc
to
29cbd4e
Compare
rzvoncek
force-pushed
the
radovan/595-hiearchical-azure
branch
from
29cbd4e
to
d951b6e
Compare
adejanovski
approved these changes
Jul 18, 2023
|
SonarCloud Quality Gate failed.
|
adejanovski
pushed a commit
that referenced
this pull request
Sep 4, 2023
adejanovski
pushed a commit
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595.
I'm proposing filtering the 0-sized files one step lower than the issue suggests. Doing the filter in list_backups() would need more changes around the codebase, for example in the functions dealing with validating the backup. This way I only had to patch the local and abstract storage list_objects().