-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reported time in seconds in metrics when backup are >24h #608
Fix reported time in seconds in metrics when backup are >24h #608
Conversation
Skunnyk
commented
Aug 3, 2023
- When backup duration is >24h, the .seconds conversion only convert the second of the day, not the full duration.
- This fix Reported time in metrics/logs is wrong when backup > 24h #606
Hi @Skunnyk, thanks for sending this PR! Issue: The integration tests are failing due to this change:
|
5944936
to
9825e60
Compare
Woopsie, was tired I guess, used |
9825e60
to
fccdc22
Compare
- When backup duration is >24h, the .seconds conversion only convert the second of the day, not the full duration. - This fix thelastpickle#606
fccdc22
to
cf95231
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks @Skunnyk