Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added check for bucket name validation #619

Merged
merged 2 commits into from
Aug 28, 2023
Merged

added check for bucket name validation #619

merged 2 commits into from
Aug 28, 2023

Conversation

RachanKaur
Copy link
Contributor

Fixes : #501

@RachanKaur RachanKaur marked this pull request as draft August 18, 2023 09:13
@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited

Codecov Report

Merging #619 (1f213c9) into master (f52ddd1) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
- Coverage   81.00%   80.98%   -0.03%     
==========================================
  Files          58       58              
  Lines        4607     4611       +4     
  Branches      740      742       +2     
==========================================
+ Hits         3732     3734       +2     
- Misses        848      850       +2     
  Partials       27       27
Files Changed Coverage Δ
medusa/config.py 88.70% <50.00%> (-1.30%) ⬇️

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RachanKaur RachanKaur self-assigned this Aug 18, 2023
@RachanKaur RachanKaur added the in-progress Issues in the state 'in-progress' label Aug 18, 2023
@RachanKaur RachanKaur marked this pull request as ready for review August 18, 2023 12:44
@RachanKaur RachanKaur added ready-for-review Issues in the state 'ready-for-review' and removed in-progress Issues in the state 'in-progress' labels Aug 18, 2023
burmanm
burmanm approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@burmanm burmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trunk errors don't seem to be from these changes.

@adejanovski adejanovski merged commit 1ad397b into master Aug 28, 2023
28 of 30 checks passed
@rzvoncek rzvoncek mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burmanm burmanm burmanm approved these changes

@rzvoncek rzvoncek Awaiting requested review from rzvoncek

Assignees

@RachanKaur RachanKaur

Labels
ready-for-review Issues in the state 'ready-for-review'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prohibit / in both the bucket name and prefix
3 participants
@RachanKaur @burmanm @adejanovski