Use Boto3 for S3 communications #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzvoncek
force-pushed
the
boto3-attempt
branch
from
6a0a7b0
to
eef23d2
Compare
rzvoncek
force-pushed
the
boto3-attempt
branch
from
eef23d2
to
6fb7ad5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This is good to go @rzvoncek, feel free to merge when it suits you. |
rzvoncek
approved these changes
Sep 13, 2023
adejanovski
added a commit
that referenced
this pull request
Sep 15, 2023
* Try using boto3 for uploads * fixes * [S3 Storage] Drop the aio-http-s3 lib, do all with boto * Update setup.py deps --------- Co-authored-by: Radovan Zvoncek <rzvoncek@gmail.com>
adejanovski
added a commit
that referenced
this pull request
Sep 15, 2023
* Try using boto3 for uploads * fixes * [S3 Storage] Drop the aio-http-s3 lib, do all with boto * Update setup.py deps --------- Co-authored-by: Radovan Zvoncek <rzvoncek@gmail.com>
|
Does this support role based authentication? |
|
Hi @H3199 . If you mean the EC2 instance role based authentication, then yes, that is still supported. A conventional role-based access control (RBAC) is something we do not support in Medusa. You could probably achieve some of it by generating different credential files to model roles or users, but that's about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #634