[Storage] Replace Azure CLI with python SDK #638
Conversation
rzvoncek
force-pushed
the
radovan/azure-sdk
branch
from
3ac153a
to
d137968
Compare
rzvoncek
changed the title
rzvoncek
force-pushed
the
radovan/azure-sdk
branch
from
d137968
to
bc17fb5
Compare
|
Rebased on the recent master. |
medusa/storage/azure_storage.py
Outdated
| name=object_key, | ||
| data=data, | ||
| overwrite=True, | ||
| max_concurrency=4, |
There was a problem hiding this comment.
Todo: after doing some benchmarks, it looks like 16 gives us better performance. Could you set this value?
| max_workers=self.config.concurrent_transfers, | ||
| multi_part_upload_threshold=int(self.config.multi_part_upload_threshold) | ||
| ) | ||
| def _get_or_create_event_loop(self) -> asyncio.AbstractEventLoop: |
There was a problem hiding this comment.
Suggestion: this seems to be repeated in all the storage classes, maybe we could refactor it to have a single version that all storage classes will use? In the abstract storage possibly?
There was a problem hiding this comment.
It's indeed repeated, I'll be pushing a different PR fixing this.
|
SonarCloud Quality Gate failed.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #638 +/- ##
==========================================
- Coverage 80.99% 80.97% -0.02%
==========================================
Files 55 53 -2
Lines 4666 4652 -14
Branches 623 661 +38
==========================================
- Hits 3779 3767 -12
+ Misses 861 857 -4
- Partials 26 28 +2
|
Fixes #628.
Fixes #637.