Consolidate the storage implementations + Remove libcloud dependency #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 80.97% 80.80% -0.17%
==========================================
Files 53 52 -1
Lines 4652 4398 -254
Branches 661 628 -33
==========================================
- Hits 3767 3554 -213
+ Misses 857 816 -41
Partials 28 28
|
rzvoncek
force-pushed
the
radovan/remove-libcloud
branch
2 times, most recently
from
162b9e9
to
4ca32ba
Compare
rzvoncek
changed the title
rzvoncek
force-pushed
the
radovan/remove-libcloud
branch
from
e722c54
to
c4e4746
Compare
rzvoncek
force-pushed
the
radovan/remove-libcloud
branch
4 times, most recently
from
eef8bbf
to
4c052a9
Compare
|
Also pushed a change to fix the bug reported by SonarCloud. |
rzvoncek
commented
Sep 18, 2023
| @@ -1,4 +1,4 @@ | |||
| FROM ubuntu:18.04 as base | |||
| k8s/Dockerfile-azure FROM ubuntu:18.04 as base | |||
There was a problem hiding this comment.
I'm actally not sure how this sneakedi n.
There was a problem hiding this comment.
lol, we're removing this file anyway.
adejanovski
approved these changes
Sep 19, 2023
| @@ -1,4 +1,4 @@ | |||
| FROM ubuntu:18.04 as base | |||
| k8s/Dockerfile-azure FROM ubuntu:18.04 as base | |||
There was a problem hiding this comment.
lol, we're removing this file anyway.
| logging.debug('Loading storage_provider: {}'.format(self._config.storage_provider)) | ||
| if self._config.storage_provider == Provider.GOOGLE_STORAGE: | ||
| if self._config.storage_provider.lower() == 'google_storage': |
There was a problem hiding this comment.
Suggestion: we should create a refactoring ticket to create new constants for the storage providers.
medusa/storage/azure_storage.py
Outdated
| name=object_key, | ||
| data=data, | ||
| overwrite=True, | ||
| max_concurrency=4, |
There was a problem hiding this comment.
Suggestion: we had settled on 16 ;)
rzvoncek
force-pushed
the
radovan/remove-libcloud
branch
from
4c052a9
to
ac8fe1c
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618 .