Add gRPC config values to configure max send and max receive sizes #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve_message_length
adejanovski
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Looks good but you have some formatting issues which break the build:
./medusa/service/grpc/server.py:55:91: E251 unexpected spaces around keyword / parameter equals
./medusa/service/grpc/server.py:55:93: E251 unexpected spaces around keyword / parameter equals
|
Right.. weirdly my flake8 reports 203 errors, so I did miss that one. |
|
Kudos, SonarCloud Quality Gate passed!
|
adejanovski
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default values to 512MB for send and 128MB to recv (I don't see why Medusa would receive larger messages in the gRPC layer).
Fixes #673