Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gRPC] Add GetBackup() endpoint #684

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

rzvoncek
Copy link
Contributor

Fixes #661 .

Copy link

sonarcloud bot commented Nov 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #684 (1ab28a0) into master (dca04bc) will increase coverage by 0.02%.
The diff coverage is 54.87%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   77.85%   77.87%   +0.02%     
==========================================
  Files          52       52              
  Lines        4516     4552      +36     
  Branches      919      919              
==========================================
+ Hits         3516     3545      +29     
- Misses        968      976       +8     
+ Partials       32       31       -1     
Files Coverage Δ
medusa/service/grpc/client.py 72.34% <66.66%> (-0.61%) ⬇️
medusa/service/grpc/medusa_pb2_grpc.py 64.17% <57.14%> (-0.83%) ⬇️
medusa/service/grpc/server.py 81.08% <82.92%> (+2.06%) ⬆️
medusa/service/grpc/medusa_pb2.py 22.00% <4.00%> (-1.92%) ⬇️

... and 1 file with indirect coverage changes

@rzvoncek rzvoncek marked this pull request as ready for review November 20, 2023 09:00
@rzvoncek rzvoncek merged commit 27fb952 into master Nov 22, 2023
31 of 33 checks passed
@rzvoncek rzvoncek deleted the radovan/grc-get-one-backup branch December 4, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a GetBackup() operation to the gRPC server
2 participants