-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent gRRPC's BackupStatus from canceling pending futures #745
Conversation
6086305
to
b3d85a4
Compare
b3d85a4
to
4e8464d
Compare
@@ -99,7 +99,7 @@ def set_backup_future(backup_name, future): | |||
|
|||
# Sets the future for a backup; unknown on overall status at this point unless already existing | |||
@staticmethod | |||
def register_backup(backup_name, is_async): | |||
def register_backup(backup_name, is_async, overwrite_existing=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: In which case is the overwrite_existing=True and is_async=True ? I can't find such invocation in current codebase so I was wondering is the overwrite_existing=False intended to be used only with async cases?
Hello, I have the same issue. Do you have any workaround to suggest me ? The backups seems completely hanged ... Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One logging is inaccurate now and I would like to understand why we're re-registering backups when checking their status.
Quality Gate passedIssues Measures |
Fixes #742.
Prior to this patch, I could even reproduce the exception from the issue in the integration tests: