Deep cloning of template definition (#2799)

* Deep cloning of template definition
thelia · Nov 26, 2020 · f2e828f · f2e828f
1 parent 021afd2
commit f2e828f
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/local/modules/TheliaSmarty/Template/SmartyParser.php b/local/modules/TheliaSmarty/Template/SmartyParser.php
@@ -416,7 +416,11 @@ public function setTemplateDefinition(TemplateDefinition $templateDefinition, $f
      */
     public function getTemplateDefinition($webAssetTemplateName = false)
     {
-        $ret = clone $this->templateDefinition;
+        // Deep clone of template definition. We could change the template descriptor of template definition,
+        // and we don't want to change the current template definition.
+
+        /** @var TemplateDefinition $ret */
+        $ret = unserialize(serialize($this->templateDefinition));
 
         if (false !== $webAssetTemplateName) {
             $customPath = str_replace($ret->getName(), $webAssetTemplateName, $ret->getPath());