Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isEmpty(), to check if $data is empty. #2204

Merged
merged 1 commit into from
Jun 28, 2016

Conversation

Doud63
Copy link
Contributor

@Doud63 Doud63 commented Jun 28, 2016

Data attribute is private.
Add method isEmpty() to check if $data is empty, to check if export is empty.

Because $data is private attribute.
@gillesbourgeat gillesbourgeat added this to the 2.4.0-alpha1 milestone Jun 28, 2016
@bibich bibich added the missing label Jun 28, 2016
@bibich bibich merged commit 2d16fe6 into thelia:master Jun 28, 2016
@bibich
Copy link
Contributor

bibich commented Jun 28, 2016

Thanks

bibich pushed a commit to bibich/thelia that referenced this pull request Aug 26, 2016
bibich added a commit that referenced this pull request Aug 30, 2016
Version 2.3.3

- Fix identical queries in the productSaleElement loop and the Product loop (related to #2249)
- Fixed and optimized content and product loops (related to #2243)
- Fix #2229 : bad resource code in MailingSystemController class (related to #2240)
- Fix #2233 : customer profile update (related to #2239)
- Fixed cancelPayment method in BasePaymentModuleController class (related to #2237)
- Fix #2215 : loop pagination cache (related to #2231)
- Hook fixes (related to #2230)
- Fix duplicates in country loop when used with "with_area" argument (related to #2222)
- Fix coupons issues (related to #2219)
- Fix for #2213 : Nesting loops with the same argument set is now working (related to #2214)
- Fix missing model on LoopResultRow (related to #2208)
- Add delimiter and enclosure for header insertion (related to #2207)
- Add reset array pointer if $data is an array. (related to #2206)
- Fixed sale edit form (related to #2205)
- Add isEmpty(), to check if $data is empty. (related to #2204)
- Check if $error exist, specific for submit type (related to #2203)
- Fix currency creation modal (The currency field is missing in the html template) (related to #2202)
- Update BO typo (related to #2191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants