Fix model generation at module activation #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucanis
pushed a commit
to Lucanis/thelia
that referenced
this pull request
Feb 21, 2022
* Fix model generation at module activation * Fix imports and multiple $cacheRefresh = false * Fixed unit tests Co-authored-by: Franck Allimant <fallimant@openstudio.fr> Co-authored-by: Vincent Lopes-Vicente <vlopesvicente@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem when a module is activated: the
postActivation()orpreActivation()methods may use the module's model classes, for example to check if module schema exists in the database. But when these methods are called, the propel cache has not been generated, and the model Base and Map classes don't exist yet in the Propel cache.A propel cache generation is now forced after the module activation state has been saved in the database, but before calls to
postActivation()orpreActivation()