Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Lint README #40

Merged
merged 1 commit into from
May 11, 2019
Merged

- Lint README #40

merged 1 commit into from
May 11, 2019

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented May 11, 2019

No description provided.

@brettz9
Copy link
Contributor Author

brettz9 commented May 11, 2019 •
edited
Loading

Btw, if you ever add @example tags within the code, ash-nazg can lint that too (just as this PR adds for Markdown files' JavaScript blocks)...

thelonious
thelonious reviewed May 11, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@thelonious
Copy link
Owner

Thanks for the fixes. BTW, what's the rational for querySelector vs getElementById?

@thelonious thelonious merged commit 0387817 into thelonious:development May 11, 2019
@brettz9
Copy link
Contributor Author

brettz9 commented May 11, 2019 •
edited
Loading

I have seen one prominent dev suggest getElementById could even be deprecated in the future, though for backward-compatibility I'd sure hope not... But it is a good practice I think as one can more consistently search one's code if one follows one form and querySelector is more capable...

@brettz9 brettz9 deleted the doc-linting branch May 11, 2019 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelonious thelonious thelonious left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brettz9 @thelonious