Add rel noopener to URLs in index.html #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Feature
|
Minor, merging. |
astorije
reviewed
Apr 15, 2017
| @@ -478,7 +478,7 @@ <h1 class="title">Help</h1> | |||
| </p> | |||
| <p> | |||
| A color reference can be found | |||
| <a href="http://www.mirc.com/colors.html" target="_blank">here</a>. | |||
| <a href="http://modern.ircdocs.horse/formatting.html#colors" target="_blank" rel="noopener">here</a>. | |||
There was a problem hiding this comment.
@DanielOaks, would you be able to serve these with HTTPS? You have free and easy options now (Let's Encrypt), and it would be a good thing for us to point our users to HTTPS content only. Thanks in advance! 😃
There was a problem hiding this comment.
Ah, didn't see the ping here, need to reduce the amount of stuff I'm following :)
Definitely, no problem! I'll yell in that other issue once it's sorted.
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Add rel noopener to URLs in index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://developers.google.com/web/tools/lighthouse/audits/noopener
Also replaced mirc colors url to @DanielOaks's documentation.