Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rel noopener to URLs in index.html #1034

Merged
merged 1 commit into from Apr 15, 2017
Merged

Add rel noopener to URLs in index.html #1034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 9 additions & 9 deletions client/index.html
View file
Open in desktop
Expand Up @@ -49,7 +49,7 @@
<h1 class="title">The Lounge is loading…</h1>
</div>
<div class="col-xs-12">
<p id="loading-page-message">Loading the app… <a href="http://enable-javascript.com/" target="_blank">Make sure to have JavaScript enabled.</a></p>
<p id="loading-page-message">Loading the app… <a href="http://enable-javascript.com/" target="_blank" rel="noopener">Make sure to have JavaScript enabled.</a></p>
<p id="loading-slow">This is taking longer than it should, there might be connectivity issues.</p>
<script async src="js/loading-slow-alert.js"></script>
</div>
Expand Down Expand Up @@ -402,7 +402,7 @@ <h3>On Windows / Linux</h3>
</p>
<p>
A color reference can be found
<a href="http://www.mirc.com/colors.html" target="_blank">here</a>.
<a href="http://modern.ircdocs.horse/formatting.html#colors" target="_blank" rel="noopener">here</a>.
</p>
</div>
</div>
Expand Down Expand Up @@ -478,7 +478,7 @@ <h3>On macOS</h3>
</p>
<p>
A color reference can be found
<a href="http://www.mirc.com/colors.html" target="_blank">here</a>.
<a href="http://modern.ircdocs.horse/formatting.html#colors" target="_blank" rel="noopener">here</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielOaks, would you be able to serve these with HTTPS? You have free and easy options now (Let's Encrypt), and it would be a good thing for us to point our users to HTTPS content only. Thanks in advance! 😃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't see the ping here, need to reduce the amount of stuff I'm following :)

Definitely, no problem! I'll yell in that other issue once it's sorted.

</p>
</div>
</div>
Expand Down Expand Up @@ -575,7 +575,7 @@ <h2>Commands</h2>
<p>
Send a <abbr title="Client-to-client protocol">CTCP</abbr>
request. Read more about this on
<a href="https://en.wikipedia.org/wiki/Client-to-client_protocol" target="_blank">the dedicated Wikipedia article</a>.
<a href="https://en.wikipedia.org/wiki/Client-to-client_protocol" target="_blank" rel="noopener">the dedicated Wikipedia article</a>.
</p>
</div>
</div>
Expand Down Expand Up @@ -809,15 +809,15 @@ <h2>About The Lounge</h2>
<p class="about">
<% if (gitCommit) { %>
The Lounge is running from source
(<a href="https://github.com/thelounge/lounge/tree/<%= gitCommit %>" target="_blank"><code><%= gitCommit %></code></a>).<br>
(<a href="https://github.com/thelounge/lounge/tree/<%= gitCommit %>" target="_blank" rel="noopener"><code><%= gitCommit %></code></a>).<br>
<% } else { %>
The Lounge is in version <strong><%= version %></strong>
(<a href="https://github.com/thelounge/lounge/releases/tag/v<%= version %>" target="_blank">See release notes</a>).<br>
(<a href="https://github.com/thelounge/lounge/releases/tag/v<%= version %>" target="_blank" rel="noopener">See release notes</a>).<br>
<% } %>

<a href="https://thelounge.github.io/" target="_blank">Website</a><br>
<a href="https://thelounge.github.io/docs/" target="_blank">Documentation</a><br>
<a href="https://github.com/thelounge/lounge/issues/new" target="_blank">Report a bug</a>
<a href="https://thelounge.github.io/" target="_blank" rel="noopener">Website</a><br>
<a href="https://thelounge.github.io/docs/" target="_blank" rel="noopener">Documentation</a><br>
<a href="https://github.com/thelounge/lounge/issues/new" target="_blank" rel="noopener">Report a bug</a>
</p>
</div>
</div>
Expand Down