Rewrite server code of channel sorting #1064
Conversation
xPaw
added
Type: Bug
Fixes server crash, fixes losing channels
| sorted.push(find); | ||
| } | ||
| this.networks.sort((a, b) => { | ||
| return order.indexOf(a.id) > order.indexOf(b.id); | ||
| }); |
There was a problem hiding this comment.
Assuming about Node's (unstable) sorting algorithm, this is at best O(n² * log n). Some people hang out in easily dozens of channels: 50 channels and that's 14k operations, 100 channels is 64k operations, etc.
I know this is not worse than it was before (I think), but do you think there is any way we can improve that? The user provides the order themselves, so in my understanding we shouldn't have to do a full sort, instead loop through the given order (which would be O(n²), not much better, surely there is a better way...)
Also, when is this needed exactly? When a user reorders their channels/networks on the UI?
There was a problem hiding this comment.
Can't rely entirely on user given input (will have to filter it to exactly contain every channel ID on the network, missing channels have to be added, invalid ones removed. This was the simplest approach.
This could be improved by modifying order into a hash map so that no indexOf calls are required.
This method is entirely just for the UI sorting.
There was a problem hiding this comment.
Ok, this can be done later though, your fix is a good thing anyway.
| // Sync order to connected clients | ||
| const syncOrder = sorted.map(obj => obj.id); | ||
| self.emit("sync_sort", {order: syncOrder, type: type, target: data.target}); | ||
| this.save(); |
There was a problem hiding this comment.
Specific reason why you separated the event emit and file save?
There was a problem hiding this comment.
Nothing specific, just didn't want to keep the variable.
Rewrite server code of channel sorting
Sending malformed
orderwould crash the server. Sending incompleteorderwould lose references to channels or networks.