Fix animation jitter when clicking the "Join a channel" button #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
reviewed
Dec 28, 2017
client/css/style.css
Outdated
| @@ -667,7 +667,8 @@ kbd { | |||
| } | |||
|
|
|||
| #sidebar .lobby .add-channel.opened { | |||
| transform: rotate(45deg); | |||
| // translateZ(0) enables hardware acceleration, this is to avoid jittering when animiating | |||
There was a problem hiding this comment.
How on Earth did that pass our CSS linter lol?!
Even my local linter (also stylelint) reported this, and actually whatever error I make in the CSS, npm run lint:css doesn't flag. There is something wrong in there, I'ma look right after...
There was a problem hiding this comment.
Too used to writing SCSS :), fixing
|
I can't see this issue on my laptop (macOS, Chrome) or phone (iOS, Safari). I'll try with an old phone (Android, Chrome) to see what happens there. Just curious, what browser are you using? The rotation doesn't seem centered, which is something I'm not seeing either. |
astorije
requested changes
Jan 4, 2018
astorije
added
the
Type: Bug
williamboman
force-pushed
the
fix/css-animation-jitter
branch
from
bfe4b53
to
7a0c768
Compare
|
Fixed comment now |
williamboman
force-pushed
the
fix/css-animation-jitter
branch
from
7a0c768
to
dfe4b2f
Compare
xPaw
approved these changes
Jan 4, 2018
astorije
approved these changes
Jan 5, 2018
astorije
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(these gifs shows the issue very poorly)
Before
After
