Document supported node version #280
Conversation
xPaw
added
the
Type: Documentation
| - '5.6' | ||
| - '4.3' | ||
| - '0.12' | ||
| - 'node' |
There was a problem hiding this comment.
I'd rather see more specific versions, like latest 4.x, 5.x and 6.x, no?
Perfect. Not limiting for us, but people are warned it's not tested/supported yet they still can run it if they really want. 👍 |
| @@ -35,6 +35,12 @@ the review process quicker and more streamlined. | |||
|
|
|||
| ## Install | |||
|
|
|||
| To use The Lounge you must have [Node.js](https://nodejs.org/en/download/) installed. | |||
| The oldest Node.js version we support is 4.2.0. | |||
There was a problem hiding this comment.
What happened before 4.2.0 (and > 0.12) so that we don't support them?
I think that in the future, we could get away with supporting current stable and LTS proposed by the Node.js website, what do you think?
There was a problem hiding this comment.
io.js happened. 4.0 was next release after 0.12. The issue discusses why we should drop the support for 0.x.
There was a problem hiding this comment.
Yeah, I meant <= 4.2 and > 4.0. Why supporting 4.2 as oldest version and not 4.0 is a better question, actually.
There was a problem hiding this comment.
It only took about a month to release 4.2.0 after 4.0.0.
4.2.0 and up is the LTS.
There was a problem hiding this comment.
Where did you get this from? 4.x is the LTS branch, and the newest version of it is the most up to date version of it. Being LTS means that they will provide security updates to it, and bug fixes. That means that each indibidual point release is not "LTS", but the branch itself is LTS.
We aren't going to update this every time there's a new patch to 4.x, so just stick it to 4.0
There was a problem hiding this comment.
See https://nodejs.org/en/download/releases/ and https://github.com/nodejs/node/blob/v4.2.0/CHANGELOG.md
Version 4.2.0 'Argon'
The first Node.js LTS release! See https://github.com/nodejs/LTS/ for details of the LTS process.
There was a problem hiding this comment.
That's just because the April releases aren't LTS until 6 months after release (to allow for the small bugs to be eeked out).
There was a problem hiding this comment.
4.4.3 released on 2016-04-12 is already LTS though.
There was a problem hiding this comment.
That's not what I meant. The major releases, not any release in April.
I think you misunderstand how LTS works. The point of LTS is that the release branch will be updated with bug fixes and security updates.
4.4.3 isn't LTS. That doesn't mean anything. 4.4.3 is, and always will be, exactly the same code. It will never change. So how can there be any support for it?
What is LTS is the 4.x release branch. They word it weirdly in node, but the point is that 4.x will get bug fixes and security updates until it is no longer LTS (next April).
When a major April release happens (4.x was different in that it was released in September, but from now on all the LTS releases will be from April major releases), 6 months later it becomes LTS, and is the stablest of the stable that they have, and will be updated with bug fixes and security updates for 18 months.
So, it doesn't mean anything to say "4.2.0 is LTS" or "4.4.3 is LTS". No, 4.x is LTS. That's all.
|
I'm happy with this now. I'm not sure there's an advantage to saying >=4.2.0, but I'm not going to argue too mcuh. I won't merge this, because @astorije didn't sound very happy with us giving an error, so I'll let him decide if he cares enough about it :-) |
Not about the error itself but with the fact that we have one more dependency just for that (at our level, regardless of what dependencies themselves have in their dependencies. That being said, everyone is 👍 so I am too, and hopefully we'll get to remove that later :-) |
Document supported node version
Fixes #231.
enginesfield only affects new installations, and only emits a warning like this:It does not block installation. I documented 4.2.0 because it's the lowest LTS version, as seen here: https://nodejs.org/en/download/releases/
It only took about a month to release 4.2.0 after 4.0.0, so it's not going to be a big problem.