Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn favicon red on page load if there are highlights #344

Merged
merged 1 commit into from
May 23, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented May 23, 2016

Fixes favicon not turning red on page load if user has unread highlights.

@xPaw xPaw added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. second review needed labels May 23, 2016
@xPaw xPaw added this to the 2.0.0 milestone May 23, 2016
@astorije
Copy link
Member

Yes! Good catch!
👍 and merging.

@astorije astorije merged commit e206ef5 into master May 23, 2016
@astorije astorije deleted the xpaw/pageload-favicon branch May 23, 2016 21:18
@astorije astorije self-assigned this May 23, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Turn favicon red on page load if there are highlights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants