-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve click handling on users and inline channels #366
Conversation
👍 seems all right to me, and one global variable down! |
@@ -206,16 +206,18 @@ $(function() { | |||
}) | |||
); | |||
renderChannel(data.chan); | |||
var chan = sidebar.find(".chan") | |||
|
|||
// Queries do not automatically focus, unless the user did a whois |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, so does this mean if I click on a user and I already have a query open with them, it won't get focus? That seems confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will, see line 666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, ok. I see.
Alright, I think this looks good to me then. Feel free to merge if you are ready for it to go in. 👍 |
Improve click handling on users and inline channels
whois
global variable which is prone to race conditions