New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add touch slideout menu for mobile #400
Conversation
I believe @astorije himself would say it's better to add this and improve it later if necessary than try to get it perfect before merging. 👍 |
Trying this on desktop and there's a bug with the menu being a little buggy:
It looks like it is not possible to open/close the menu while on the login window. When you tap something in chat view (to close the menu), it still triggers the click on whatever you tapped (e.g. if you tap on a nick, sidebar closes, and it executes a /whois) |
1- I semi-fixed it, but master does that as well in an even more silly way (at least for me). It's hard to fix due to the way we do the menu (we actually put the menu with 2- Good catch, fixed 3- Semi-fixed. Since every window have its own menu button for some reason, by the time we get the event to fire on |
@maxpoulin64, could you rebase this with master please? |
Sure, will do tomorrow or saturday as soon as I get a chance. |
@astorije: done, pretty minor conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to switch to a dedicated dependency for that later, but it will do until then. 👍
If @xPaw or @williamboman or @MaxLeiter want to give it a try, I think this is ready to go 🎉. |
I ran this for quite a while before the first 2.0 rc and it worked great then. Gonna update my instance to run latest master + interesting PRs (including this) again. |
I really like the change, but it feels a little too fast. Could we make the transition a little longer? |
From IRC
|
I'm in favor of shipping this now and improving later. It's not like it's broken, just it could be slightly improved. What do you think @MaxLeiter? |
Fine with me, @astorije |
Add touch slideout menu for mobile
Implements #393 with a slightly modified version of the demo solution I had. The only problem with it that I'm aware of is that the transition is fixed, so if you're like me and swipe the slider really fast it feels laggy when you release the finger as the animation still plays at normal speed. I didn't feel like implementing the maths to support inertia, but if that's bugging too much people I will add it.